-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenTelemetry extension helpers #7127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
tag: no release notes
Changes to exclude from release notes
inst: opentelemetry
OpenTelemetry instrumentation
labels
Jun 5, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 16 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060264
Total [baseline] (10.359 s) : 0, 10359115
Agent [candidate] (1.058 s) : 0, 1058249
Total [candidate] (10.38 s) : 0, 10379903
section appsec
Agent [baseline] (1.186 s) : 0, 1185506
Total [baseline] (10.547 s) : 0, 10547363
Agent [candidate] (1.175 s) : 0, 1175206
Total [candidate] (10.456 s) : 0, 10456029
section iast
Agent [baseline] (1.175 s) : 0, 1174585
Total [baseline] (10.751 s) : 0, 10750901
Agent [candidate] (1.166 s) : 0, 1165616
Total [candidate] (10.789 s) : 0, 10788894
section profiling
Agent [baseline] (1.268 s) : 0, 1267896
Total [baseline] (10.593 s) : 0, 10592674
Agent [candidate] (1.26 s) : 0, 1259696
Total [candidate] (10.611 s) : 0, 10611382
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (654.105 ms) : 0, 654105
BytebuddyAgent [candidate] (652.075 ms) : 0, 652075
GlobalTracer [baseline] (313.552 ms) : 0, 313552
GlobalTracer [candidate] (313.506 ms) : 0, 313506
AppSec [baseline] (49.971 ms) : 0, 49971
AppSec [candidate] (50.127 ms) : 0, 50127
Remote Config [baseline] (736.589 µs) : 0, 737
Remote Config [candidate] (719.026 µs) : 0, 719
Telemetry [baseline] (7.519 ms) : 0, 7519
Telemetry [candidate] (7.505 ms) : 0, 7505
section appsec
BytebuddyAgent [baseline] (680.283 ms) : 0, 680283
BytebuddyAgent [candidate] (674.022 ms) : 0, 674022
GlobalTracer [baseline] (297.936 ms) : 0, 297936
GlobalTracer [candidate] (295.93 ms) : 0, 295930
AppSec [baseline] (153.594 ms) : 0, 153594
AppSec [candidate] (152.841 ms) : 0, 152841
IAST [baseline] (22.821 ms) : 0, 22821
IAST [candidate] (20.414 ms) : 0, 20414
Remote Config [baseline] (688.116 µs) : 0, 688
Remote Config [candidate] (937.037 µs) : 0, 937
Telemetry [baseline] (6.932 ms) : 0, 6932
Telemetry [candidate] (6.86 ms) : 0, 6860
section iast
BytebuddyAgent [baseline] (784.102 ms) : 0, 784102
BytebuddyAgent [candidate] (778.003 ms) : 0, 778003
GlobalTracer [baseline] (295.254 ms) : 0, 295254
GlobalTracer [candidate] (293.227 ms) : 0, 293227
AppSec [baseline] (46.689 ms) : 0, 46689
AppSec [candidate] (46.595 ms) : 0, 46595
IAST [baseline] (26.924 ms) : 0, 26924
IAST [candidate] (26.231 ms) : 0, 26231
Remote Config [baseline] (593.932 µs) : 0, 594
Remote Config [candidate] (593.987 µs) : 0, 594
Telemetry [baseline] (7.729 ms) : 0, 7729
Telemetry [candidate] (7.722 ms) : 0, 7722
section profiling
BytebuddyAgent [baseline] (667.132 ms) : 0, 667132
BytebuddyAgent [candidate] (662.209 ms) : 0, 662209
GlobalTracer [baseline] (387.838 ms) : 0, 387838
GlobalTracer [candidate] (385.433 ms) : 0, 385433
AppSec [baseline] (51.175 ms) : 0, 51175
AppSec [candidate] (50.974 ms) : 0, 50974
Remote Config [baseline] (798.223 µs) : 0, 798
Remote Config [candidate] (745.969 µs) : 0, 746
Telemetry [baseline] (7.368 ms) : 0, 7368
Telemetry [candidate] (7.304 ms) : 0, 7304
ProfilingAgent [baseline] (96.477 ms) : 0, 96477
ProfilingAgent [candidate] (96.566 ms) : 0, 96566
Profiling [baseline] (96.502 ms) : 0, 96502
Profiling [candidate] (96.591 ms) : 0, 96591
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072679
Total [baseline] (8.612 s) : 0, 8611547
Agent [candidate] (1.057 s) : 0, 1057411
Total [candidate] (8.522 s) : 0, 8522407
section iast
Agent [baseline] (1.18 s) : 0, 1179921
Total [baseline] (9.044 s) : 0, 9044187
Agent [candidate] (1.167 s) : 0, 1167247
Total [candidate] (9.039 s) : 0, 9038717
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173616
Total [baseline] (9.013 s) : 0, 9012921
Agent [candidate] (1.166 s) : 0, 1166073
Total [candidate] (8.985 s) : 0, 8984875
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177885
Total [baseline] (9.04 s) : 0, 9039690
Agent [candidate] (1.159 s) : 0, 1159321
Total [candidate] (8.973 s) : 0, 8973128
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (661.476 ms) : 0, 661476
BytebuddyAgent [candidate] (651.713 ms) : 0, 651713
GlobalTracer [baseline] (317.041 ms) : 0, 317041
GlobalTracer [candidate] (312.978 ms) : 0, 312978
AppSec [baseline] (50.903 ms) : 0, 50903
AppSec [candidate] (50.062 ms) : 0, 50062
Remote Config [baseline] (756.537 µs) : 0, 757
Remote Config [candidate] (725.519 µs) : 0, 726
Telemetry [baseline] (7.713 ms) : 0, 7713
Telemetry [candidate] (7.549 ms) : 0, 7549
section iast
BytebuddyAgent [baseline] (788.258 ms) : 0, 788258
BytebuddyAgent [candidate] (779.006 ms) : 0, 779006
GlobalTracer [baseline] (294.82 ms) : 0, 294820
GlobalTracer [candidate] (293.316 ms) : 0, 293316
AppSec [baseline] (46.826 ms) : 0, 46826
AppSec [candidate] (46.627 ms) : 0, 46627
IAST [baseline] (25.169 ms) : 0, 25169
IAST [candidate] (25.082 ms) : 0, 25082
Remote Config [baseline] (620.305 µs) : 0, 620
Remote Config [candidate] (595.7 µs) : 0, 596
Telemetry [baseline] (10.791 ms) : 0, 10791
Telemetry [candidate] (9.342 ms) : 0, 9342
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.045 ms) : 0, 784045
BytebuddyAgent [candidate] (777.756 ms) : 0, 777756
GlobalTracer [baseline] (294.694 ms) : 0, 294694
GlobalTracer [candidate] (293.606 ms) : 0, 293606
AppSec [baseline] (46.746 ms) : 0, 46746
AppSec [candidate] (46.68 ms) : 0, 46680
IAST [baseline] (25.633 ms) : 0, 25633
IAST [candidate] (26.422 ms) : 0, 26422
Remote Config [baseline] (595.556 µs) : 0, 596
Remote Config [candidate] (585.552 µs) : 0, 586
Telemetry [baseline] (8.517 ms) : 0, 8517
Telemetry [candidate] (7.711 ms) : 0, 7711
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.083 ms) : 0, 786083
BytebuddyAgent [candidate] (774.359 ms) : 0, 774359
GlobalTracer [baseline] (296.919 ms) : 0, 296919
GlobalTracer [candidate] (292.39 ms) : 0, 292390
AppSec [baseline] (49.085 ms) : 0, 49085
AppSec [candidate] (48.42 ms) : 0, 48420
IAST [baseline] (23.509 ms) : 0, 23509
IAST [candidate] (22.795 ms) : 0, 22795
Remote Config [baseline] (574.519 µs) : 0, 575
Remote Config [candidate] (577.088 µs) : 0, 577
Telemetry [baseline] (8.234 ms) : 0, 8234
Telemetry [candidate] (7.51 ms) : 0, 7510
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 7 metrics, 21 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section baseline
no_agent (1.72 ms) : 1695, 1745
. : milestone, 1720,
appsec (2.193 ms) : 2161, 2225
. : milestone, 2193,
appsec_no_iast (2.215 ms) : 2183, 2247
. : milestone, 2215,
iast (1.856 ms) : 1825, 1886
. : milestone, 1856,
profiling (1.87 ms) : 1838, 1902
. : milestone, 1870,
tracing (1.887 ms) : 1855, 1918
. : milestone, 1887,
section candidate
no_agent (1.695 ms) : 1670, 1720
. : milestone, 1695,
appsec (2.184 ms) : 2152, 2216
. : milestone, 2184,
appsec_no_iast (2.21 ms) : 2179, 2241
. : milestone, 2210,
iast (1.917 ms) : 1885, 1948
. : milestone, 1917,
profiling (1.932 ms) : 1896, 1968
. : milestone, 1932,
tracing (1.87 ms) : 1837, 1903
. : milestone, 1870,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section baseline
no_agent (454.603 µs) : 426, 483
. : milestone, 455,
iast (585.98 µs) : 554, 618
. : milestone, 586,
iast_FULL (692.233 µs) : 660, 724
. : milestone, 692,
iast_GLOBAL (615.029 µs) : 584, 646
. : milestone, 615,
iast_HARDCODED_SECRET_DISABLED (588.518 µs) : 557, 620
. : milestone, 589,
iast_INACTIVE (561.247 µs) : 530, 593
. : milestone, 561,
iast_TELEMETRY_OFF (572.598 µs) : 542, 604
. : milestone, 573,
tracing (535.883 µs) : 506, 566
. : milestone, 536,
section candidate
no_agent (453.205 µs) : 424, 482
. : milestone, 453,
iast (587.206 µs) : 556, 619
. : milestone, 587,
iast_FULL (685.672 µs) : 654, 718
. : milestone, 686,
iast_GLOBAL (618.66 µs) : 587, 651
. : milestone, 619,
iast_HARDCODED_SECRET_DISABLED (581.247 µs) : 549, 613
. : milestone, 581,
iast_INACTIVE (557.917 µs) : 527, 589
. : milestone, 558,
iast_TELEMETRY_OFF (578.037 µs) : 545, 611
. : milestone, 578,
tracing (544.464 µs) : 515, 574
. : milestone, 544,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section baseline
no_agent (1.545 ms) : 1533, 1558
. : milestone, 1545,
appsec (2.664 ms) : 2604, 2723
. : milestone, 2664,
iast (2.333 ms) : 2263, 2402
. : milestone, 2333,
iast_GLOBAL (2.389 ms) : 2319, 2459
. : milestone, 2389,
profiling (2.201 ms) : 2140, 2262
. : milestone, 2201,
tracing (2.167 ms) : 2110, 2225
. : milestone, 2167,
section candidate
no_agent (1.543 ms) : 1531, 1556
. : milestone, 1543,
appsec (2.671 ms) : 2612, 2731
. : milestone, 2671,
iast (2.368 ms) : 2295, 2440
. : milestone, 2368,
iast_GLOBAL (2.411 ms) : 2340, 2483
. : milestone, 2411,
profiling (2.204 ms) : 2144, 2265
. : milestone, 2204,
tracing (2.155 ms) : 2098, 2212
. : milestone, 2155,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~416f6771a8, baseline=1.35.0-SNAPSHOT~239d9a91ac
dateFormat X
axisFormat %s
section baseline
no_agent (21.197 s) : 21197000, 21197000
. : milestone, 21197000,
appsec (21.64 s) : 21640000, 21640000
. : milestone, 21640000,
iast (24.23 s) : 24230000, 24230000
. : milestone, 24230000,
iast_GLOBAL (24.97 s) : 24970000, 24970000
. : milestone, 24970000,
profiling (21.201 s) : 21201000, 21201000
. : milestone, 21201000,
tracing (21.482 s) : 21482000, 21482000
. : milestone, 21482000,
section candidate
no_agent (20.423 s) : 20423000, 20423000
. : milestone, 20423000,
appsec (21.284 s) : 21284000, 21284000
. : milestone, 21284000,
iast (24.751 s) : 24751000, 24751000
. : milestone, 24751000,
iast_GLOBAL (25.079 s) : 25079000, 25079000
. : milestone, 25079000,
profiling (20.51 s) : 20510000, 20510000
. : milestone, 20510000,
tracing (21.637 s) : 21637000, 21637000
. : milestone, 21637000,
|
PerfectSlayer
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: opentelemetry
OpenTelemetry instrumentation
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers those helpers discovered at build time by OpenTelemetry's muzzle plugin, as well as additional ones declared by the extension itself.
Jira ticket: APMAPI-6